Add Preference Page for Managing Floating Windows#484
Merged
jmmaranan merged 10 commits intoforge-ext:mainfrom Oct 31, 2025
Merged
Add Preference Page for Managing Floating Windows#484jmmaranan merged 10 commits intoforge-ext:mainfrom
jmmaranan merged 10 commits intoforge-ext:mainfrom
Conversation
Contributor
Author
jmmaranan
approved these changes
Oct 31, 2025
Collaborator
jmmaranan
left a comment
There was a problem hiding this comment.
Looks good. I am not able to test it though
GFiamoncini
added a commit
to GFiamoncini/forge
that referenced
this pull request
Mar 12, 2026
After PR forge-ext#484, the window-toggle-float and window-toggle-always-float shortcuts stopped working. The root cause was that addFloatOverride and removeFloatOverride save overrides via configMgr (disk), but isFloatingExempt reads from this.windowProps (in-memory cache) which was never refreshed after the save. Fixes forge-ext#492, forge-ext#495"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR introduces a new "Windows" settings page in the Forge extension preferences that allows users to view and manage floating window overrides directly from the GUI. This replaces the need to manually edit configuration files and provides a more user-friendly interface for managing which windows should float.
Changes Made
🆕 New Features
🔧 Technical Improvements
🛠️ Infrastructure Updates
Files Changed
Core Functionality
Configuration & Schema
Translations
Build System
How It Works
Testing
✅ Tested floating window removal functionality
✅ Verified real-time reload mechanism works correctly
✅ Confirmed changes persist across extension restarts
✅ Updated translation files are properly formatted